Conversation
…3` + 3.12 subclassing of native types) (#5823) * add test for subclassing variable-sized type * fix type confusion inside `get_contents_of_obj` * newsfragment
Merging this PR will degrade performance by 15.87%
Performance Changes
Comparing 
Footnotes |
Contributor
|
Perhaps #5815 is also worth adding? |
Member
Author
|
Ah yes sorry, was processing my inbox LIFO and hadn't got to that yet! Will get it merged and included 👍 |
Member
Author
|
(will probably complete this release in the morning now that we're waiting for #5815 to merge.) |
davidhewitt
force-pushed
the
release-0.28.2
branch
from
ed0b0af to
0cb9b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships the fix in #5823
I'll push this live as soon as CI succeeds.